Making watch work with read_namespaced_pod_log #93
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @mbohlool |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 92.11% 92.29% +0.18%
==========================================
Files 13 13
Lines 1217 1246 +29
==========================================
+ Hits 1121 1150 +29
Misses 96 96
Continue to review full report at Codecov.
|
|
please add a test case for this. |
| resp.close() | ||
| resp.release_conn() | ||
| if self.resource_version is not None: | ||
| kwargs['resource_version'] = self.resource_version | ||
| else: |
There was a problem hiding this comment.
Do you need the else: break here?
There was a problem hiding this comment.
Yes. The log streaming does not have resource_version. So once the response finishes, you have to stop.
There was a problem hiding this comment.
In fact that was not good because using break inside finally swallows up the exception. I change it to setting a flag.
mitar
force-pushed
the
watch_and_logs
branch
from
34a4b58
to
8e6f043
Compare
k8s-ci-robot
added
size/M
|
As much as I want to merge this I don't have ownership of this repo :) |
It swallows exceptions.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mitar, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fixes kubernetes-client/python#199.